Add Montgomery u32 backend for BabyBear #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 71.14% 71.32% +0.17%
==========================================
Files 153 155 +2
Lines 33129 33537 +408
==========================================
+ Hits 23570 23920 +350
- Misses 9559 9617 +58 ☔ View full report in Codecov by Sentry. |
| /// | ||
| /// Converts a value from Montgomery domain using reductions mod p | ||
| #[inline(always)] | ||
| const fn monty_reduce(x: u64, mu: &u32, q: &u32) -> u32 { |
There was a problem hiding this comment.
Think better name is montgomery_reduction
There was a problem hiding this comment.
You are right. Renamed in 32ed5e3
diegokingston
approved these changes
Dec 26, 2024
pablodeymo
reviewed
Jan 3, 2025
|
|
||
| #[inline(always)] | ||
| pub const fn mul(a: &u32, b: &u32, q: &u32, mu: &u32) -> u32 { | ||
| let x = *a as u64 * *b as u64; |
There was a problem hiding this comment.
Suggested change
| let x = *a as u64 * *b as u64; | |
| let x = u64::from(*a) * u64::from(*b); |
There was a problem hiding this comment.
We tried to replace as with from but we can't use from inside a constant function.
ColoCarletti
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Montgomery u32 backend for BabyBear
Description
This PR implements a 32-bit Montgomery arithmetic backend for BabyBear finite field operations.
These operations show significant performance improvements versus the actual u64 backend.
Performance parity with Plonky3 is achieved
Results for 1.000.000 operations
Type of change
Checklist